Skip to content

TYP: pd.merge annotation is incorrect #48098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Aug 15, 2022 · 3 comments
Closed

TYP: pd.merge annotation is incorrect #48098

jbrockmendel opened this issue Aug 15, 2022 · 3 comments
Labels
Bug Needs Triage Issue that has not been reviewed by a pandas team member

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Aug 15, 2022 •
edited
Loading

For left_on and right_on it says IndexLabel | None, where IndexLabel = Hashable | Sequence[Hashable]. But it can also be AnyArrayLike or sequence thereof. So Something like Hashable | AnyArrayLike | Sequence[Hashable | AnyArrayLike]
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 15, 2022
@twoertwein
Copy link
Member

I think there are currently many places where Series and Index are accepted by the implementation but not by the type annotations as Series/Index are not Hashable.

@phofl
Copy link
Member

phofl commented Aug 16, 2022

This is a dup of #43215

@jbrockmendel
Copy link
Member Author

Closing as duplicate of #43215, thanks @phofl

@stevenlis stevenlis mentioned this issue Nov 14, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twoertwein @jbrockmendel @phofl