-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Unclear documentation for Period Construction #4591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@sunaymehta Sure we would love to accept a PR! The location of the pandas/pandas/_libs/tslibs/period.pyx Line 2375 in eab7226
ATM what is missing is some examples on how to construct a period. |
Hey since the Issue is still open. I am currently looking into it. |
Is this still open? Can I take this? |
Hi @jreback, Is this issue still open? I would like to work on it. |
Pull requests are welcome |
Hey, would be interested to work on this as a good first issue! |
take |
The documentation is unclear as to what the date passed to a
Period
means: whether it is the start date or the end date of the period. Convention is that fiscal quarters are usually stated by the date the quarter ends, whereas weeks are many times stated by the day week starts. This is especially unclear given that the defaultfreq='W'
isW-SUN
which means the "week ending on Sunday" whereas one convention is to show weeks starting on Sunday.I would recommend clearing this up in the documentation.
The text was updated successfully, but these errors were encountered: