Skip to content

DOC: Unclear documentation for Period Construction #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cancan101 opened this issue Aug 17, 2013 · 8 comments · Fixed by #47321
Closed

DOC: Unclear documentation for Period Construction #4591

cancan101 opened this issue Aug 17, 2013 · 8 comments · Fixed by #47321
Assignees

Comments

@cancan101
Copy link
Contributor

The documentation is unclear as to what the date passed to a Period means: whether it is the start date or the end date of the period. Convention is that fiscal quarters are usually stated by the date the quarter ends, whereas weeks are many times stated by the day week starts. This is especially unclear given that the default freq='W' is W-SUN which means the "week ending on Sunday" whereas one convention is to show weeks starting on Sunday.

I would recommend clearing this up in the documentation.

@ShaharNaveh
Copy link
Member

@sunaymehta Sure we would love to accept a PR!


The location of the Period documentation is at

class Period(_Period):

ATM what is missing is some examples on how to construct a period.

@nexus-hash
Copy link

Hey since the Issue is still open. I am currently looking into it.

@nexus-hash
Copy link

From your reference, I guess you want to keep some examples of how to construct a Period, here-
Screenshot 2021-01-18 at 10 22 02 PM

@NishitaPatnaik21
Copy link

Is this still open? Can I take this?

@sonia1goyal
Copy link

Hi @jreback, Is this issue still open? I would like to work on it.

@MarcoGorelli
Copy link
Member

Pull requests are welcome

@athielem
Copy link

athielem commented Apr 5, 2022

Hey, would be interested to work on this as a good first issue!

@jackgoldsmith4
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants