Skip to content

2to3 refactor broke vbenches #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Aug 6, 2013 · 2 comments · Fixed by #4478
Closed

2to3 refactor broke vbenches #4477

ghost opened this issue Aug 6, 2013 · 2 comments · Fixed by #4478
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Aug 6, 2013

looks like lmap is now called by some vbenches, which breaks
the tests on all older versions.

.....................................................groupby_transform died with:
name 'lmap' is not defined
Skipping...

groupby_transform died with:
name 'lmap' is not defined
Skipping...

#4384, #4474

@jtratner
Copy link
Contributor

jtratner commented Aug 6, 2013

@y-p how do the vbenches work? Are they supposed to contain only code that
works through the last X revisions?

@ghost
Copy link
Author

ghost commented Aug 6, 2013

test_perf is meant to allow before/after perf for sanity checking PRs, but the underlying vbench
tool and vbench suite is geared towards long term perf tracking.
With that in mind, vbenches should be portable as far back into pandas' history as is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant