Skip to content

DOC: DataFrame.groupby() includes no mention of some important functionality #43839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
tobiasmcnulty opened this issue Oct 1, 2021 · 3 comments · Fixed by #43880
Closed
1 task done

DOC: DataFrame.groupby() includes no mention of some important functionality #43839

tobiasmcnulty opened this issue Oct 1, 2021 · 3 comments · Fixed by #43880
Milestone

Comments

@tobiasmcnulty
Copy link
Contributor

  • I have checked that the issue still exists on the latest versions of the docs on master here

Location of the documentation

https://pandas.pydata.org/docs/dev/reference/api/pandas.DataFrame.groupby.html

Documentation problem

The reference for DataFrame.groupby is absent of any reference to iterating through groups, which seems like a fairly critical piece of information (I ended up brewing my own solution, before eventually finding the user guide link). A link to the user guide is included, but it's easy to miss.

Suggested fix for documentation

The documentation could be improved by including some suggestions of what one might find in the user guide. For example, the text "See the user guide for more." could be replaced with something like the following:

See the user guide for detailed usage and examples, including splitting an object into groups, iterating through groups, selecting a group, aggregation, and more.

@tobiasmcnulty tobiasmcnulty added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 1, 2021
@mzeitlin11
Copy link
Member

Thanks for reporting this @tobiasmcnulty! Agreed that your suggestion would be an improvement, would you be interested in making a pr?

@mzeitlin11 mzeitlin11 added Groupby and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 2, 2021
@mzeitlin11 mzeitlin11 added this to the Contributions Welcome milestone Oct 2, 2021
@tobiasmcnulty
Copy link
Contributor Author

Happy to! Though I'm struggling to find where this is in the repo, if someone could possibly point me in the right direction...

@mzeitlin11
Copy link
Member

Happy to! Though I'm struggling to find where this is in the repo, if someone could possibly point me in the right direction...

This one is hard to find :) I think it's at pandas/core/shared_docs.py, around L140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants