-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Make the entire codebase Python3 compatible without using 2to3 #4375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Could try running https://github.com/mitsuhiko/python-modernize on it. Actually, I'm going to do it now and see what happens. |
Check it - bunch of changes...worth thinking through https://github.com/jtratner/pandas/tree/python-modernize-it . Going to see what happens if we remove 2to3 as well... Main thing are the xrange --> range changes. Maybe use |
aaannnd it has tons of errors to fix... |
is there a way to essentially find all d these errors then fix them (by doing code changes) gradually using a tool to find them but shouldn't have a dep for the actual changes |
|
|
Yeah, that's what I'm doing. I'm just going fix by fix on this which makes it easier to do. Basically six converts everything to iterators and then you need to explicitly choose to convert things to lists. |
Right now I'm doing u"some string" --> six.u("some string"), etc. |
ok |
@jtratner after all ur prs pandas is going to be sparkling clean ❇️ |
haha, frankly these fixes end up being great ways to learn the code base, because they break minor things / show up issues and then I can fix them 😄 |
iterkv
The text was updated successfully, but these errors were encountered: