Skip to content

CI: Run Sdist less often(only on master/nightlies and PRs labeled build) #43745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lithomas1 opened this issue Sep 25, 2021 · 1 comment · Fixed by #44731
Closed

CI: Run Sdist less often(only on master/nightlies and PRs labeled build) #43745

lithomas1 opened this issue Sep 25, 2021 · 1 comment · Fixed by #44731
Assignees
Labels
Build Library building on various platforms CI Continuous Integration
Milestone

Comments

@lithomas1
Copy link
Member

We might want to consider running the sdist checks less. They take around 10-15 minutes each and personally, I have only seen them fail once or twice ever(which were on PRs that changed build stuff).

We could try moving them to only run on PRs that are labeled "Build" and on merged commits first, and then maybe look to move them to nightly.

cc @fangchenli @simonjayhawkins

@lithomas1 lithomas1 added Build Library building on various platforms CI Continuous Integration Needs Discussion Requires discussion from core team before further action labels Sep 25, 2021
@simonjayhawkins
Copy link
Member

I think OK to only run on commits to master only as a first step. This should still provide more visibility of issues than the nightly builds.

@lithomas1 lithomas1 removed the Needs Discussion Requires discussion from core team before further action label Dec 3, 2021
@lithomas1 lithomas1 self-assigned this Dec 3, 2021
@lithomas1 lithomas1 added this to the 1.5 milestone Feb 26, 2022
@lithomas1 lithomas1 mentioned this issue Mar 24, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants