-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: dtypes on empty frame are incorrect #4272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this got messed up after that.....need an explicit test for it....thanks |
I have put together commit which better special cases empty DataFrames and does fix this. However it breaks test_apply_empty_infer_type whose tests seems a little sketchy to me, for example:
Tests that this ought to be a DataFrame... whereas I think this ought to be a Series. ...there really is some ambiguity in when DataFrame should be pushed down to Series in an apply and same with columns names/series name. |
This is a series (in master)
|
@hayd can you revisit this....and see if you can fix the isues here? thxs |
@jreback yeah, will have a look at the weekend, will at least write all the cases down (where I think there is ambiguity). IIRC there was an issue where fixing one thing that seemed obviously wrong broke another which had seemed obviously correct. |
@hayd actually I am not so sure that this is wrong (nor does it really matter), and default dtype is np.float64, as the dtypes would be changed/inferred if stuff was added.....going to close as not a bug (if you disagree, can pls reopen and move to 0.14) |
expected
The text was updated successfully, but these errors were encountered: