Skip to content

CI: categorical failures #42088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mzeitlin11 opened this issue Jun 17, 2021 · 3 comments · Fixed by #42089
Closed

CI: categorical failures #42088

mzeitlin11 opened this issue Jun 17, 2021 · 3 comments · Fixed by #42089
Labels
Categorical Categorical Data Type CI Continuous Integration
Milestone

Comments

@mzeitlin11
Copy link
Member

Seeing

~/work/pandas/pandas/pandas/core/indexes/base.py in get_indexer(self, target, method, limit, tolerance)
106
   3411             # potential fastpath
107
   3412             # get an indexer for unique categories then propagate to codes via take_nd
108
-> 3413             categories_indexer = self.get_indexer(target.categories)
109
   3414             indexer = algos.take_nd(categories_indexer, target.codes, fill_value=-1)
110
   3415 
111

112
RecursionError: maximum recursion depth exceeded while calling a Python object
113
<<<-------------------------------------------------------------------------

along with a bunch of other categorical related failures. Guessing cause may be #41934, cc @jbrockmendel

@mzeitlin11 mzeitlin11 added Categorical Categorical Data Type CI Continuous Integration labels Jun 17, 2021
@jbrockmendel
Copy link
Member

is there a particular test i should run to reproduce locally?

@jbrockmendel
Copy link
Member

never mind, found a bunch

@jbrockmendel
Copy link
Member

Tentatively Looks like changing self.get_indexer(target.categories) to self._get_indexer(target.categories) in indexes.base L3413 does the trick, I'll make a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants