Skip to content

PERF: performance regression in indexing UInt64Index with an array-like #41873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorisvandenbossche opened this issue Jun 8, 2021 · 1 comment · Fixed by #41972
Closed

PERF: performance regression in indexing UInt64Index with an array-like #41873

jorisvandenbossche opened this issue Jun 8, 2021 · 1 comment · Fixed by #41972
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Milestone
1.3

Comments

@jorisvandenbossche
Copy link
Member

See eg https://pandas.pydata.org/speed/pandas/#indexing.NumericSeriesIndexing.time_loc_list_like?python=3.8&Cython=0.29.21&p-index_dtype=%3Cclass%20'pandas.core.indexes.numeric.UInt64Index'%3E&p-index_structure='unique_monotonic_inc'

Up to 180x slowdown in the indexing.NumericSeriesIndexing.time_loc_array/time_loc_list_like benchmarks with UInt64Index.

Indicated range of responsible commits is 21d6145...c9d50d8

Didn't check, but potential candidate: #41777 or #41804

cc @jbrockmendel
@jorisvandenbossche jorisvandenbossche added Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version labels Jun 8, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Jun 8, 2021
@jbrockmendel
Copy link
Member

#41777 is more plausible than #41804

@jbrockmendel jbrockmendel mentioned this issue Jun 12, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

PERF: indexing on UInt64Index with int64s jbrockmendel/pandas
2 participants
@jorisvandenbossche @jbrockmendel