Skip to content

STYLE disallow assigning to single-letter variable names #41719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue May 29, 2021 · 4 comments
Closed

STYLE disallow assigning to single-letter variable names #41719

MarcoGorelli opened this issue May 29, 2021 · 4 comments
Labels
Code Style Code style, linting, code_checks

Comments

@MarcoGorelli
Copy link
Member

We keep leaving this comment to each other and to contributors in review, so let's add a rule for it

PR should be made to https://github.com/pandas-dev/pandas-dev-flaker if anyone wants to give this a go
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label May 29, 2021
@jbrockmendel
Copy link
Member

id like this, but in fairness its mostly me leaving that comment

@MarcoGorelli
Copy link
Member Author

😆 pretty sure I've seen it from others too

@mgmanzella tagging you in case you'd be interested in giving this a go, as you'd expressed interest in implementing more linting rules

@lithomas1 lithomas1 added this to the Contributions Welcome milestone Jun 2, 2021
@MarcoGorelli
Copy link
Member Author

done in pandas-dev-flaker

next step will be to gradually introduce it to the pandas codebase

@MarcoGorelli
Copy link
Member Author

closing for now as the PR's already been made to pandas-dev-flaker, enabling it will be another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @MarcoGorelli @lithomas1