Skip to content

WEB: Format broken in team page (maintainers grid) #41438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue May 12, 2021 · 6 comments · Fixed by #41447
Closed

WEB: Format broken in team page (maintainers grid) #41438

datapythonista opened this issue May 12, 2021 · 6 comments · Fixed by #41447
Assignees
Labels
Milestone

Comments

@datapythonista
Copy link
Member

Looks like the format of our team grid is broken when there is only one maintainer in a row, check Patrick here: https://pandas.pydata.org/about/team.html

The website generates invisible cards in the last row so the size stays the same, regardless of the actual (visible) number of cards. But something doesn't seem to be working as expected.

@attack68
Copy link
Contributor

there are flex-wraps within flex wraps:

<div class="row">
    <div class="card-container">
        <div class="card"></div>
        ..
        <div class="card"></div>
    </div>
    ...
    <div class="card-container">
        <div class="card"></div>
        ..
        <div class="card"></div>
    </div>
</div>

might be better just to create a single div as the flex container and let all the name cards organise themselves based on browser size?

<div class="main-container">
    <div class="card"></div>
    ..
    <div class="card"></div>
    <div class="card"></div>
    ..
    <div class="card"></div>
</div>

@datapythonista
Copy link
Member Author

That sounds good. I think I started implementing that, but couldn't get it working, and that's why I implemented the current approach. In any case, happy with any approach that fixes the problem.

@calvh
Copy link
Contributor

calvh commented May 13, 2021

I'd like to work on this

@calvh
Copy link
Contributor

calvh commented May 13, 2021

take

@calvh
Copy link
Contributor

calvh commented May 13, 2021

Sorry @wesm and @gfyoung I did not realize the build script was making API requests to github for data on all the maintainers. I exceeded the API rate limit for your accounts. I hope that won't be too much of an issue. I do apologize for not reading the script completely before running it.

@datapythonista
Copy link
Member Author

datapythonista commented May 13, 2021

Sorry @wesm and @gfyoung I did not realize the build script was making API requests to github for data on all the maintainers. I exceeded the API rate limit for your accounts. I hope that won't be too much of an issue. I do apologize for not reading the script completely before running it.

The quota is the number of requests you can do from your own IP address to the GitHub API. It happened to fail when fetching their profiles, but it's your own quota, and didn't affect anyone else, don't worry.

When building the website for development is unfortunately expected to run out of that quota. Not sure if we still have a flag in the script to continue the build if that quota is exceeded. But in your case, since you're testing the page that needs the GitHub data, there is nothing else that can be done than waiting one hour for the quota to reset. I guess you already seen that.

@jreback jreback added this to the 1.3 milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants