Skip to content

BUG: New numpy dev caused ci to fail #40874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
phofl opened this issue Apr 11, 2021 · 5 comments · Fixed by #41015
Closed
1 task done

BUG: New numpy dev caused ci to fail #40874

phofl opened this issue Apr 11, 2021 · 5 comments · Fixed by #41015
Labels
CI Continuous Integration Dependencies Required and optional dependencies Upstream issue Issue related to pandas dependency
Milestone

Comments

@phofl
Copy link
Member

phofl commented Apr 11, 2021

  • I have checked that this issue has not already been reported.

The weekly wheel of numpy changed and caused our ci to fail

Worked:
https://github.com/pandas-dev/pandas/runs/2314968903

First failure:
https://github.com/pandas-dev/pandas/runs/2315938439

Numpy wheels:

First:
https://pypi.anaconda.org/scipy-wheels-nightly/simple/numpy/1.21.0.dev0%2B1199.g623bc1fae/numpy-1.21.0.dev0%2B1199.g623bc1fae-cp38-cp38-manylinux2010_x86_64.whl

Second:
https://pypi.anaconda.org/scipy-wheels-nightly/simple/numpy/1.21.0.dev0%2B1229.g36eb76c9d/numpy-1.21.0.dev0%2B1229.g36eb76c9d-cp38-cp38-manylinux2010_x86_64.whl

cc @simonjayhawkins is this an issue for the 1.2.4 release?

@phofl phofl added Bug Needs Triage Issue that has not been reviewed by a pandas team member CI Continuous Integration Dependencies Required and optional dependencies Upstream issue Issue related to pandas dependency and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 11, 2021
@simonjayhawkins
Copy link
Member

cc @simonjayhawkins is this an issue for the 1.2.4 release?

maybe. i'll merge (and backport) #40850 an we'll know for sure.

@jreback
Copy link
Contributor

jreback commented Apr 11, 2021

cc @seberg is this expected?

@simonjayhawkins simonjayhawkins added this to the 1.2.4 milestone Apr 11, 2021
@seberg
Copy link
Contributor

seberg commented Apr 11, 2021

Seems like a bug on first sight, I will dig into where it comes from tomorrow probably. @simonjayhawkins you don't happen to know a more minimal example of what misbehaves? (My first guess right now, is that I broke some __array_wrap__ or so logic in the ufuncs)

@phofl
Copy link
Member Author

phofl commented Apr 11, 2021

@seberg
It comes down to this:

import operator
import numpy as np

result = operator.__floordiv__(np.array([True, False, False]), True)

With the new wheel this has dtype uint8 while we got int8 previously.

@seberg
Copy link
Contributor

seberg commented Apr 11, 2021

Thanks! I was indeed barking up the wrong tree then since I had not realized it was division specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies Upstream issue Issue related to pandas dependency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants