Skip to content

TST: rewrite test_expressions.py to use pytest idioms #40497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorisvandenbossche opened this issue Mar 18, 2021 · 1 comment · Fixed by #49422
Closed

TST: rewrite test_expressions.py to use pytest idioms #40497

jorisvandenbossche opened this issue Mar 18, 2021 · 1 comment · Fixed by #49422
Labels
expressions pd.eval, query Testing pandas testing functions or related to the test suite

Comments

@jorisvandenbossche
Copy link
Member

The test_expressions.py test file could be updated to use some more pytest features (eg using fixtures for the test data, using fixture for the setup/teardown to set _MIN_ELEMENTS)
@jorisvandenbossche jorisvandenbossche added the Testing pandas testing functions or related to the test suite label Mar 18, 2021
@jorisvandenbossche jorisvandenbossche added this to the Contributions Welcome milestone Mar 18, 2021
@jorisvandenbossche jorisvandenbossche mentioned this issue Mar 18, 2021
Merged
@jorisvandenbossche jorisvandenbossche mentioned this issue Apr 20, 2021
Merged
@mroeschke mroeschke added the expressions pd.eval, query label Aug 19, 2021
@jandirdlctm
Copy link

Can I take this?

@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@mroeschke mroeschke mentioned this issue Oct 31, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expressions pd.eval, query Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLN: test_expressions.py mroeschke/pandas
3 participants
@jorisvandenbossche @mroeschke @jandirdlctm