Skip to content

STYLE: cpplint (unintentionally?) skips pandas/_libs/src/ujson/ #39347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Jan 23, 2021 · 2 comments · Fixed by #39352
Closed

STYLE: cpplint (unintentionally?) skips pandas/_libs/src/ujson/ #39347

MarcoGorelli opened this issue Jan 23, 2021 · 2 comments · Fixed by #39352
Assignees
@gustavocmaciel
Labels
Code Style Code style, linting, code_checks
Milestone
1.3

Comments

@MarcoGorelli
Copy link
Member

In code_checks.sh we have

cpplint --quiet --extensions=c,h --headers=h --recursive --filter=-readability/casting,-runtime/int,-build/include_subdir pandas/_libs/src/*.h pandas/_libs/src/parser pandas/_libs/ujson pandas/_libs/tslibs/src/datetime pandas/_libs/*.cpp

However, pandas/_libs/ujson doesn't exist.

I presume cpplint should be running on pandas/_libs/src/ujson/ instead?
@MarcoGorelli MarcoGorelli changed the title STYLE: cpplint (unintentionally?) skips STYLE: cpplint (unintentionally?) skips pandas/_libs/src/ujson/ Jan 23, 2021
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Jan 23, 2021
@gustavocmaciel
Copy link
Contributor

Yeah, that's true. It looks like pandas/_libs/src/ujson/ is the only possible path.

Adding the missing /src/ to the path will fix it, I suppose.

@gustavocmaciel
Copy link
Contributor

take

@gustavocmaciel gustavocmaciel mentioned this issue Jan 23, 2021
Merged
1 task
@jreback jreback added this to the 1.3 milestone Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gustavocmaciel gustavocmaciel

Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

STYLE: Fix incorrect path to ujson directory gustavocmaciel/pandas
3 participants
@jreback @MarcoGorelli @gustavocmaciel