Skip to content

BUG: read_excel does not use pyxlsb for xlsb files when engine is None #38667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhshadrach opened this issue Dec 23, 2020 · 3 comments
Closed
Assignees
Labels
Bug Duplicate Report Duplicate issue or pull request IO Excel read_excel, to_excel

Comments

@rhshadrach
Copy link
Member

rhshadrach commented Dec 23, 2020

From pandas.tests.io.excel.test_excel_read_binary_via_read_excel (currently only in #38571):

        if read_ext == ".xlsb" and engine == "pyxlsb":
            with pytest.raises(IOError, match="File contains no valid workbook part"):
                with open("test1" + read_ext, "rb") as f:
                    pd.read_excel(f)

This should instead determine that pyxlsb should be used when installed and no error should be raised.

@rhshadrach rhshadrach added Bug IO Excel read_excel, to_excel labels Dec 23, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Dec 24, 2020
@mzeitlin11
Copy link
Member

Related to #35416

@lithomas1
Copy link
Member

take

@rhshadrach
Copy link
Member Author

Thanks @mzeitlin11, this is a duplicate.

@rhshadrach rhshadrach modified the milestones: 1.3, No action Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Duplicate Report Duplicate issue or pull request IO Excel read_excel, to_excel
Projects
None yet
Development

No branches or pull requests

4 participants