Skip to content

DEPS: unpin sphinx from doc build #38600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Dec 21, 2020 · 2 comments · Fixed by #38657
Closed

DEPS: unpin sphinx from doc build #38600

jreback opened this issue Dec 21, 2020 · 2 comments · Fixed by #38657
Labels
Dependencies Required and optional dependencies Docs
Milestone
1.2

Comments

@jreback
Copy link
Contributor

jreback commented Dec 21, 2020 •
edited
Loading

once warnings are fixed in updated sphinx can unpin #38598
@jreback jreback added this to the 1.3 milestone Dec 21, 2020
@jreback jreback added Docs Dependencies Required and optional dependencies labels Dec 21, 2020
@jreback
Copy link
Contributor Author

jreback commented Dec 21, 2020

xref dask/dask#7001

seems 3.4.1 should fix.

@jorisvandenbossche jorisvandenbossche mentioned this issue Dec 23, 2020
Merged
@jorisvandenbossche
Copy link
Member

It's probably not caused by that issue linked there, since the warnings we get is not for methods/attributes that are slots.
Looking a bit into it, and I think it's caused by sphinx-doc/sphinx#8533. We will have to see if this was intentional change or not on the sphinx side, but for the short term I put up a workaround: #38657

@jreback jreback modified the milestones: 1.3, 1.2 Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dependencies Required and optional dependencies Docs
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

DOC/CI: fix class alias docstrings for sphinx 3.4 + unpin sphinx jorisvandenbossche/pandas
2 participants
@jreback @jorisvandenbossche