ci/after_script.sh missing?

[gliptak]

https://travis-ci.org/gliptak/pandas/jobs/8002655

$ ci/print_versions.py
$ ci/after_script.sh
/home/travis/build.sh: line 208: ci/after_script.sh: No such file or directory
Done. Your build exited with 1.

[cpcloud]

that should be removed from travis since there's no after_script.sh anywhere in pandas...pr?

[cpcloud]

nevermind i did it

[jreback]

what happend to the after script? was it ever there? what runs it?

[cpcloud]

was in .travis.yml in the after_script clause. was being run by travis after ci/print_versions.py

[cpcloud]

oh the script itself i dunno i can check the git history if uwant

[cpcloud]

git log -p -S 'after_script' will show it

[cpcloud]

doesn't look like that script was ever there...

[jreback]

so just called in ci/script.sh?

[cpcloud]

no travis calls it after ci/print_versions.py

[cpcloud]

do this

git log -S 'after_script' --pretty=format:'%h' | while read p; do
    git diff-tree --name-only $p HEAD | grep 'after_script.sh'
done

should not show anything. which means none of the cchanges mentioning after_script actually added a file with the name after_script.sh

[cpcloud]

that might take a while since it has to search the entire history cuz it uses pickaxe

[jreback]

so travis calls it by default....then I guess we should have one (that does nothing), right?

[cpcloud]

Only called if it's in the config... Not called by default

[jreback]

so it must be in the config then?

[cpcloud]

hence my change here i just removed it...

[jreback]

ok...duh!....go ahead