-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: any_* fixtures are confusingly named #38017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
makes sense |
Proposed naming seems to make sense (note I removed the 1.2 milestone, since I don't think this is in any way important for the release? So we can use the milestone to track release critical issues) |
@jreback I would love to work on this issue. If you agree then I will start working on it. |
take |
I apologize, I cannot deal with this problem now. |
Hey @jreback I want to take this issue, but being it my very first contribution, how to check the what datatype does the variable takes, like is it numpy or ea or both. Sorry for this silly question |
@Anupam-USP look at the |
Hey, I am still looking for response on this, not stuck on this but wanted to complete this issue! |
Can you rephrase the question? I don't understand what you're looking for. |
@jreback @jbrockmendel Since this issue was most probably lying dormant, I took some liberty and made some changes. Can you review the PR? |
the naming on the any_* fixtures in
pandas/conftest.py
is pretty confusingany_int_dtype
(numpy only)any_int_nullable_dtype
(EA only)any_numeric_dtype
both numpy & EAany_real_dtype
both numpy int & floatsint_dtype
signed numpy intsfor example
so we need dtypes that are numpy_only and EA only and numpy + EA both for ints & floats
would propose something like
any_int_numpy_dtype
any_int_ea_dtype
any_int_dtype
-> both numpy + easame for float
then
any_numeric_nump_dtype
any_numeric_ea_dtype
for float + int
which means we rename
sint_dtype
->any_signed_int_numpy_dtype
I think this would require a PR to organize, a PR to create new names & fix everything.
The text was updated successfully, but these errors were encountered: