Skip to content

Remove the Label alias in pandas._typing. #37134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonjayhawkins opened this issue Oct 15, 2020 · 0 comments · Fixed by #39107
Closed

Remove the Label alias in pandas._typing. #37134

simonjayhawkins opened this issue Oct 15, 2020 · 0 comments · Fixed by #39107
Labels
Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking
Milestone
1.3

Comments

@simonjayhawkins
Copy link
Member

in mypy 0.790 bugfix (open PR to update #37108)

Make None compatible with Hashable (PR 9371)

we have an alias in pandas._typing for Label to work around this bug.

I propose that we now remove the Label alias for two reasons.

  1. It has been the source of some confusion, especially when using Optional[Label]
  2. for the API, users would know what Hashable is without needing to look up the alias.
@simonjayhawkins simonjayhawkins added Typing type annotations, mypy/pyright type checking Needs Discussion Requires discussion from core team before further action labels Oct 15, 2020
@simonjayhawkins simonjayhawkins mentioned this issue Nov 16, 2020
Merged
@simonjayhawkins simonjayhawkins mentioned this issue Jan 11, 2021
Merged
4 tasks
@jreback jreback added this to the 1.3 milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

TYP: replace Label alias from pandas._typing with Hashable simonjayhawkins/pandas
2 participants
@jreback @simonjayhawkins