Skip to content

Add CI check to check that ensure_clean is used instead of os.remove #37095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Oct 13, 2020 · 0 comments · Fixed by #37097
Closed

Add CI check to check that ensure_clean is used instead of os.remove #37095

MarcoGorelli opened this issue Oct 13, 2020 · 0 comments · Fixed by #37097
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Milestone
1.2

Comments

@MarcoGorelli
Copy link
Member

xref #34385 (review)

This could also be a pre-commit hook

Opening this issue as a placeholder so we don't forget
@MarcoGorelli MarcoGorelli added CI Continuous Integration Code Style Code style, linting, code_checks labels Oct 13, 2020
@MarcoGorelli MarcoGorelli added this to the Contributions Welcome milestone Oct 13, 2020
@MarcoGorelli MarcoGorelli mentioned this issue Oct 13, 2020
Merged
@jnecus jnecus mentioned this issue Oct 13, 2020
Merged
5 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Update code_checks.sh to check for instances of os.remove jnecus/pandas
2 participants
@jreback @MarcoGorelli