CLN: unify numpy.random-related imports

[onshek]

Location of the imports

pandas/pandas/tests/plotting/test_hist_method.py

Lines 3 to 4 in 8a25b23

	import numpy as np
	from numpy.random import randn

Imports problem

All numpy-related imports are only about numpy.random including randint, choice, normal, etc
Part of numpy.random-related imports use aliases

Suggested fix for imports

eg: import numpy as np
 && np.ranom.randn --> from numpy.random import randn
from numpy.random import randn --> import numpy as np
 && np.ranom.randn

[jreback]

yeah this would be fine to change
but if we do then pls implement a code_check to enforce this

[onshek]

yeah this would be fine to change
but if we do then pls implement a code_check to enforce this

Do you mean adding a new code_check to check the whole package instead of the single file?

[jreback]

yes see code_check.sh

[onshek]

take

[mroeschke]

My 2 cents; I would actually prefer to standardize in the other direction.

i.e. use np.random.choice() directly instead of from np.random import choice; choice()

[jreback]

sorry i think i misread the top

we always want fully qualified things eg

np.random.randn

no aliases for these

[onshek]

Um...it seems I did the opposite. will be corrected later.