Skip to content

API: why do DataFrame bool ops have default_axis=columns while arith/cmp have default_axis=None? #36788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Oct 1, 2020 · 0 comments · Fixed by #36793
Closed

API: why do DataFrame bool ops have default_axis=columns while arith/cmp have default_axis=None? #36788

jbrockmendel opened this issue Oct 1, 2020 · 0 comments · Fixed by #36793
Labels
Bug Needs Triage Issue that has not been reviewed by a pandas team member
Milestone
1.2

Comments

@jbrockmendel
Copy link
Member

Changing the default_axis to None doesn't break any tests, and that would allow for a bit of code simplification. So is there a reason for the current implementation?
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 1, 2020
@jbrockmendel jbrockmendel mentioned this issue Oct 1, 2020
Merged
5 tasks
@jreback jreback added this to the 1.2 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Milestone
1.2
2 participants
@jreback @jbrockmendel