Skip to content

PERF: large perf regression in DataFrame repr #36636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorisvandenbossche opened this issue Sep 25, 2020 · 1 comment · Fixed by #36638
Closed

PERF: large perf regression in DataFrame repr #36636

jorisvandenbossche opened this issue Sep 25, 2020 · 1 comment · Fixed by #36638
Assignees
@ivanovmg
Labels
Output-Formatting __repr__ of pandas objects, to_string Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Milestone
1.2

Comments

@jorisvandenbossche
Copy link
Member

On master:

In [1]: df = pd.DataFrame(np.random.randn(1_000_000, 10))

In [3]: %timeit repr(df) 
2.5 s ± 340 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

while on released version this takes around 20ms

cc @ivanovmg I suppose this is from #36434
@jorisvandenbossche jorisvandenbossche added Performance Memory or execution speed performance Output-Formatting __repr__ of pandas objects, to_string Regression Functionality that used to work in a prior pandas version labels Sep 25, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.2 milestone Sep 25, 2020
@jorisvandenbossche jorisvandenbossche mentioned this issue Sep 25, 2020
Merged
5 tasks
@ivanovmg
Copy link
Member

@jorisvandenbossche, good catch. I'm on my way to fix it.

@ivanovmg ivanovmg self-assigned this Sep 25, 2020
@ivanovmg ivanovmg mentioned this issue Sep 25, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanovmg ivanovmg

Labels
Output-Formatting __repr__ of pandas objects, to_string Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

PERF: fix long string representation ivanovmg/pandas
2 participants
@jorisvandenbossche @ivanovmg