Skip to content

TST: Add test for GroupBy.describe() with duplicate columns #35423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
smithto1 opened this issue Jul 27, 2020 · 0 comments · Fixed by #35424
Closed
3 tasks done

TST: Add test for GroupBy.describe() with duplicate columns #35423

smithto1 opened this issue Jul 27, 2020 · 0 comments · Fixed by #35424
Labels
Apply Apply, Aggregate, Transform, Map Groupby Testing pandas testing functions or related to the test suite
Milestone
1.2

Comments

@smithto1
Copy link
Member

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.

While working on #35314 I made a change that broke GroupBy.apply if you called it on a DataFrame with duplicate columns; however, this break as not caught by any test. Was just caught on inpsection: #35314 (comment)

This issue is just to add a test for this case to ensure it works and doesn't break again in the future.
@smithto1 smithto1 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 27, 2020
@smithto1 smithto1 mentioned this issue Jul 27, 2020
Merged
4 tasks
@simonjayhawkins simonjayhawkins added Groupby Testing pandas testing functions or related to the test suite Apply Apply, Aggregate, Transform, Map and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 27, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

TST: adding test for .describe() with duplicate columns smithto1/pandas
2 participants
@smithto1 @simonjayhawkins