-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: warning from setuptools (Numpy Dev Build Failures) #35252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
To reproduce In [1]: import pandas
In [2]: import setuptools
/Users/taugspurger/Envs/pandas-dev/lib/python3.7/site-packages/setuptools/distutils_patch.py:26: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors. Please use Setuptools' objects directly or at least import Setuptools first.
"Distutils was imported before Setuptools. This usage is discouraged " That's with setuptools 49.2.0. I think this is because pandas uses But for now let's just fix CI by silencing that warning to |
Right now I think the two longer-term solutions are to either
If we go the vendoring route, we'd need |
if it is only to avoid a warning in Also, if distutils is discouraged like that, it's a bit a pitty there is no better (stdlib) solution for parsing versions. The setuptools issue where it was introduced: pypa/setuptools#2230 |
Agreed. Seems like the thing that should be built in :/
Probably. In theory this makes using pandas & setuptools together a bit fragile, but perhaps we just wait for complaints? |
Does using and think we can use |
setuptools is not a runtime dependency (only an install dependency), so that does not directly help (except if we make packaging or setuptools a runtime dependency, but IMO I wouldn't do that just for the version checks) |
Agreed. The warning has been suppressed and I don't see "distutils" imported anywhere. Anything left to do here? |
I don't see this error in our builds anymore (maybe the warning disappeared as setuptools is v 60ish now). Going to close for now but can reopen if we see this again |
e.g : https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=39110&view=logs&j=3a03f79d-0b41-5610-1aa4-b4a014d0bc70&t=4d05ed0e-1ed3-5bff-dd63-1e957f2766a9&l=195
The text was updated successfully, but these errors were encountered: