Skip to content

REF: Dataframe.__init__ #35226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jul 11, 2020 · 1 comment
Closed

REF: Dataframe.__init__ #35226

jreback opened this issue Jul 11, 2020 · 1 comment
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Enhancement ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code

Comments

@jreback
Copy link
Contributor

jreback commented Jul 11, 2020

in #34875 several checks were added to the main Dataframe construction to handle extension arrays, in particular extension scalars

this introduced multiple checks like

if is_extensions_drype(,,):
...
else:
...

these should be refactored and pushed down to more understandable functions

this construction is now so complicated that bugs are certain to happen

@jreback jreback added Constructors Series/DataFrame/Index/pd.array Constructors ExtensionArray Extending pandas with custom dtypes or arrays. Dtype Conversions Unexpected or buggy dtype conversions Refactor Internal refactoring of code labels Jul 11, 2020
@jreback jreback added this to the Contributions Welcome milestone Jul 11, 2020
@tomaszps tomaszps removed their assignment Oct 8, 2020
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@jbrockmendel
Copy link
Member

constructor has been nicely-ish refactored since OP, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Enhancement ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code
Projects
None yet
Development

No branches or pull requests

4 participants