Skip to content

Performance regression in replace.Convert.time_replace #35053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Jun 29, 2020 · 4 comments
Closed

Performance regression in replace.Convert.time_replace #35053

TomAugspurger opened this issue Jun 29, 2020 · 4 comments
Labels
Blocker Blocking issue or pull request for an upcoming release Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Milestone
1.1

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jun 29, 2020 •
edited
Loading

#34999 caused a 2x slowdown in replace.Convert.time_replace (https://pandas.pydata.org/speed/pandas/index.html#replace.Convert.time_replace?p-constructor=%27Series%27&p-replace_data=%27Timestamp%27&commits=dbfbef7eaea7f23a42d9a65344b5745fc055f5b4)
@TomAugspurger TomAugspurger added Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version Blocker Blocking issue or pull request for an upcoming release labels Jun 29, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone Jun 29, 2020
@TomAugspurger TomAugspurger mentioned this issue Jun 29, 2020
Merged
5 tasks
@jbrockmendel
Copy link
Member

How do you get 100x? do you mean 100ms?

@TomAugspurger
Copy link
Contributor Author

Sorry, meant 100% (2x). Edited.

@jbrockmendel
Copy link
Member

Assuming this was caused by#34999, this is something we just have to live with. The previous behavior was incorrect.

@TomAugspurger
Copy link
Contributor Author

Perhaps a fluke in the timing? The latest runs are back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker Blocking issue or pull request for an upcoming release Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@TomAugspurger @jbrockmendel