Skip to content

API: Remove PeriodDtype.dtype_code from public API #34735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Jun 12, 2020 · 1 comment · Fixed by #34796
Closed

API: Remove PeriodDtype.dtype_code from public API #34735

TomAugspurger opened this issue Jun 12, 2020 · 1 comment · Fixed by #34796
Labels
API Design Blocker Blocking issue or pull request for an upcoming release
Milestone
1.1

Comments

@TomAugspurger
Copy link
Contributor

On master PeriodDtype has a .dtype_code attribute.

In [5]: pd.PeriodDtype('D').dtype_code
Out[5]: 6000

That wasn't there in 1.0.x. I think we want it to be private.
@TomAugspurger TomAugspurger added API Design Blocker Blocking issue or pull request for an upcoming release labels Jun 12, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone Jun 12, 2020
@jbrockmendel
Copy link
Member

sure

@TomAugspurger TomAugspurger mentioned this issue Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Blocker Blocking issue or pull request for an upcoming release
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

API: Removed PeriodDtype.dtype_code from public API TomAugspurger/pandas
2 participants
@TomAugspurger @jbrockmendel