Skip to content

REF: Move sampling logic into algorithms.py #34483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsaxton opened this issue May 30, 2020 · 0 comments · Fixed by #42233
Closed

REF: Move sampling logic into algorithms.py #34483

dsaxton opened this issue May 30, 2020 · 0 comments · Fixed by #42233
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Refactor Internal refactoring of code
Milestone
1.4

Comments

@dsaxton
Copy link
Member

dsaxton commented May 30, 2020

#34069 is implementing a sampling procedure for groupby which then uses the same from core/generic.py, however it may be preferable to implement lower-level code in core/algorithms.py which then both can share.
@dsaxton dsaxton added Needs Triage Issue that has not been reviewed by a pandas team member Usage Question Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Refactor Internal refactoring of code and removed Usage Question labels May 30, 2020
@mroeschke mroeschke removed the Needs Triage Issue that has not been reviewed by a pandas team member label May 30, 2020
@mzeitlin11 mzeitlin11 mentioned this issue Jun 25, 2021
Merged
4 tasks
@jreback jreback added this to the 1.4 milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

PERF/REF: groupby sample mzeitlin11/pandas
3 participants
@jreback @dsaxton @mroeschke