Skip to content

CLN: is pandas/tests/data used? #34427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue May 28, 2020 · 4 comments · Fixed by #34458
Closed

CLN: is pandas/tests/data used? #34427

MarcoGorelli opened this issue May 28, 2020 · 4 comments · Fixed by #34458
Assignees
Labels
Clean good first issue Testing pandas testing functions or related to the test suite
Milestone

Comments

@MarcoGorelli
Copy link
Member

In pandas/tests/data there are two files:

iris.csv
tips.csv

Both of these files are also in pandas/tests/io/data/csv.

Do they need to be in both places? If not, can they be removed from one of them?

@najann
Copy link
Contributor

najann commented May 28, 2020

output_duplicate_files

Apparently, iris.csv is only needed in pandas/tests/data.
However, I'm not sure about tips.csv: It is definitely accessed in pandas/tests/data, too. There is no direct reference to the file in pandas/tests/io/data/csv but to the one in pandas/tests/io/parser/data. So, if that one contains parsed files from tests/io/data tips.csvis needed there.

@WillAyd
Copy link
Member

WillAyd commented May 28, 2020

Yea I think should clean these up. @najann interested in a PR?

@najann
Copy link
Contributor

najann commented May 29, 2020

Yes, I can do that @WillAyd :)

@najann
Copy link
Contributor

najann commented May 29, 2020

take

@jreback jreback added this to the 1.1 milestone May 29, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants