Skip to content

Rethink Inlining? #33926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
WillAyd opened this issue May 1, 2020 · 2 comments
Open

Rethink Inlining? #33926

WillAyd opened this issue May 1, 2020 · 2 comments
Labels
Build Library building on various platforms

Comments

@WillAyd
Copy link
Member

WillAyd commented May 1, 2020

ref #33886 (comment)

We use the inline keyword pretty liberally in our Cython extensions, with the thought that this probably improves performance. However, running GCC with -Winline as a flag produces a ton of warnings that we aren't actually inlining things. Some of these may even do more harm than good (just a hunch, I have no expertise with inline)

I've attached warnings from a clean build on master. Not sure all of these are necessarily even just from pandas but may be worth a look for anyone interested

warnings.log.zip
@WillAyd WillAyd mentioned this issue May 1, 2020
Merged
5 tasks
@jbrockmendel jbrockmendel added the Build Library building on various platforms label May 7, 2020
@jbrockmendel
Copy link
Member

Maybe add to the agenda for next week's call? seems like "no strong opinion" is the modal response so far

@WillAyd WillAyd mentioned this issue Nov 23, 2022
Merged
@WillAyd
Copy link
Member Author

WillAyd commented Feb 26, 2024

Interestingly enough it looks like usage of the inline keyword was causing a regression in #57618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WillAyd @jbrockmendel