Skip to content

DOC:https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.reindex.html#pandas.DataFrame.reindex #33888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2bon opened this issue Apr 30, 2020 · 8 comments

Comments

@2bon
Copy link

2bon commented Apr 30, 2020

Location of the documentation

https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.reindex.html#pandas.DataFrame.reindex

Documentation problem

Returns
DataFrame with changed index.

Suggested fix for documentation

fix= a NEW DataFrame instance with changed index,NOT changing old instance .
why? I thought old instance has changed index.

@2bon 2bon added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 30, 2020
2bon added a commit to 2bon/match2StringDBs that referenced this issue Apr 30, 2020
@MarcoGorelli
Copy link
Member

Thanks @2bon for the report - the docs currently say

A new object is produced unless the new index is equivalent to the current one and copy=False.

but if you think it could be clarified, pull requests are welcome https://pandas.pydata.org/pandas-docs/stable/development/contributing.html

@MarcoGorelli MarcoGorelli removed the Needs Triage Issue that has not been reviewed by a pandas team member label Apr 30, 2020
@2bon
Copy link
Author

2bon commented May 7, 2020

Thx @MarcoGorelli 😊,
Could we make it ez 2 read, pls!
now is 2 ivory-Towered and confusing😥. Big Pain Point!
(unless the new index is equivalent to the current one ) if so, why do I reIndex? let's ignore 1%% corner case

@gauravchandok
Copy link

Is someone working on this issue or can I take it?

@MarcoGorelli
Copy link
Member

@gauravchandok sure, pull requests are welcome if you think the docs can be clarified

@2bon
Copy link
Author

2bon commented May 25, 2020

@gauravchandok ya, thx

@2bon
Copy link
Author

2bon commented Jun 28, 2020

Hi, any update?

@MarcoGorelli
Copy link
Member

Hi, any update?

as mentioned above, pull requests are welcome, see here for how to contribute

@MarcoGorelli
Copy link
Member

Closing for now as there doesn't seem to be any traction here, but feel free to open a PR if you think this docstring can be clarified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants