Skip to content

TST: add Feather V2 round-trip test #33810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Apr 26, 2020 · 4 comments
Closed

TST: add Feather V2 round-trip test #33810

jreback opened this issue Apr 26, 2020 · 4 comments
Assignees
@alimcmaster1
Labels
IO Parquet parquet, feather Testing pandas testing functions or related to the test suite

Comments

@jreback
Copy link
Contributor

jreback commented Apr 26, 2020

no that pyarrow 0.17 has landed, we should have a round-trip Feather V2 test to ensure we have dtype preservation (we can likely re-use some of our test frames from the parquet tests).
@jreback jreback added Testing pandas testing functions or related to the test suite IO Data IO issues that don't fit into a more specific label IO Parquet parquet, feather Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 26, 2020
@jreback jreback added this to the Contributions Welcome milestone Apr 26, 2020
@jreback
Copy link
Contributor Author

jreback commented Apr 26, 2020

cc @alimcmaster1

@mroeschke mroeschke removed IO Data IO issues that don't fit into a more specific label Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 26, 2020
@alimcmaster1
Copy link
Member

will take a look

@alimcmaster1 alimcmaster1 self-assigned this Apr 26, 2020
@jorisvandenbossche
Copy link
Member

I think this was already covered by #33422

@mroeschke
Copy link
Member

Yeah looks like there are round tripping tests in pandas/tests/io/test_feather.py so I think we're okay to close

@jorisvandenbossche jorisvandenbossche modified the milestones: Contributions Welcome, No action Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimcmaster1 alimcmaster1

Labels
IO Parquet parquet, feather Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jreback @jorisvandenbossche @mroeschke @alimcmaster1