-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: rename_axis 'columns' param #33564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @Toussaic for the report - are you insterested in submitting a pull request? https://pandas.pydata.org/pandas-docs/stable/development/contributing.html |
take |
Sorry, I'm not a real dev. But after reading other docstring, maybe there should be a wrapper in "series.py" with a different docstring, like for "series.py:rename". Don't know... |
I would like to work on this issue if possible |
@TapanGujjar it seems @benrhodeland is already working on this, but there are other good first issues you're welcome to submit a pull request for! |
Hello, is @benrhodeland on this issue? Because I would like to work on this as well. |
Given the silence, you're probably OK to take it - PRs are welcome! |
Ok, thanks @MarcoGorelli . Should I add the explanation inside "Notes" or just after the parameter "index, columns" text? |
Example :
Except :
TypeError: rename_axis() got an unexpected keyword argument "columns"
Description :
The documentation shows a "columns" param which is not allowed for a Series. There should be a note to explain this parameter only apply for DataFrame.
Link :
pandas/pandas/core/generic.py
Lines 1110 to 1279 in 3adf334
INSTALLED VERSIONS
commit : None
python : 3.8.2.final.0
python-bits : 64
OS : Windows
OS-release : 10
machine : AMD64
processor : Intel64 Family 6 Model 158 Stepping 10, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : fr_FR.cp1252
pandas : 1.0.3
numpy : 1.18.1
pytz : 2019.3
dateutil : 2.8.1
pip : 20.0.2
setuptools : 46.1.3.post20200330
Cython : None
pytest : None
hypothesis : None
sphinx : 2.4.4
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : 2.11.1
IPython : 7.13.0
pandas_datareader: None
bs4 : None
bottleneck : None
fastparquet : None
gcsfs : None
lxml.etree : None
matplotlib : 3.1.3
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : None
pytables : None
pytest : None
pyxlsb : None
s3fs : None
scipy : 1.4.1
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
xlwt : None
xlsxwriter : None
numba : None
The text was updated successfully, but these errors were encountered: