You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During my work on generalizing our rolling window functions, @mroeschke and @jreback have pointed out that it would be useful to expose a couple BaseIndexer subclasses as a part of our api (in pandas.api.indexers, to be specific). For instance, forward-looking windows are fairly common in signal analysis and the like, and it would benefit users if we had a default implementation of those.
This is the implementation I'm currently using for testing:
This should be rewritten to avoid the for loop, as it slows the function down a lot.
We could also add a backward indexer for completeness or skip it, because it can be done by supplying an integer when creating the rolling window object. Tell me what you think.
I'd be happy to submit a PR with a proposed implementation in a day or two.
Implementation details
I think we can put the implementation of the new class/classes in pandas.core.window.indexers.
Problem description
During my work on generalizing our rolling window functions, @mroeschke and @jreback have pointed out that it would be useful to expose a couple
BaseIndexer
subclasses as a part of our api (in pandas.api.indexers, to be specific). For instance, forward-looking windows are fairly common in signal analysis and the like, and it would benefit users if we had a default implementation of those.This is the implementation I'm currently using for testing:
This should be rewritten to avoid the for loop, as it slows the function down a lot.
We could also add a backward indexer for completeness or skip it, because it can be done by supplying an integer when creating the rolling window object. Tell me what you think.
I'd be happy to submit a PR with a proposed implementation in a day or two.
Implementation details
I think we can put the implementation of the new class/classes in
pandas.core.window.indexers
.Cross-references
xref #32865
xref #33180
The text was updated successfully, but these errors were encountered: