Skip to content

DOC: Mention black and PEP8 in pandas style guide #31828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsaxton opened this issue Feb 9, 2020 · 2 comments · Fixed by #32043
Closed

DOC: Mention black and PEP8 in pandas style guide #31828

dsaxton opened this issue Feb 9, 2020 · 2 comments · Fixed by #32043
Labels

Comments

@dsaxton
Copy link
Member

dsaxton commented Feb 9, 2020

black and PEP8 are pretty important elements of code style in pandas but they aren't mentioned in the style guide, so it may make sense to include them.

https://pandas.pydata.org/pandas-docs/stable/development/code_style.html

@dsaxton dsaxton changed the title Mention black and PEP8 in pandas style guide DOC: Mention black and PEP8 in pandas style guide Feb 9, 2020
@alimcmaster1
Copy link
Member

We mention them in the contributing guide?

(Maybe a link would be helpful)

https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#python-pep8-black

@gfyoung
Copy link
Member

gfyoung commented Feb 10, 2020

The purpose of the style guide to express particular style points we follow. black and pep8 are just tools we use to enforce general "stylistic correctness".

I agree with @alimcmaster1 that linking is probably a sensible thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants