Skip to content

SAS class comment mentions inexistant path #31391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Jan 28, 2020 · 2 comments
Closed

SAS class comment mentions inexistant path #31391

MarcoGorelli opened this issue Jan 28, 2020 · 2 comments

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jan 28, 2020

pandas/asv_bench/benchmarks/io/sas.py :

class SAS:

params = ["sas7bdat", "xport"]
param_names = ["format"]

def setup(self, format):
    # Read files that are located in 'pandas/io/tests/sas/data'

However, the files are in 'pandas/tests/io/sas/data'.

EDIT:
unrelated typo: there's lots of places in the codebase that use "rather then" instead of "rather than". As this is also a minor typo that doesn't affect any code, I think it'd be OK to address both in the same pull request

@jeandersonbc
Copy link
Contributor

Hi @MarcoGorelli,
about the "rather then" typo, I found those occurrences:

$ grep -nri "rather then" ..
../doc/source/whatsnew/v0.13.0.rst:217:- default for `display.max_seq_len` is now 100 rather then `None`. This activates
../pandas/core/config_init.py:9:module is imported, register them here rather then in the module.
../pandas/io/formats/printing.py:77:# Try to use these as much as possible rather then rolling your own.
../pandas/io/formats/printing.py:101:    rather then calling this directly.
../pandas/io/formats/printing.py:136:    rather then calling this directly.
../pandas/tests/io/formats/test_format.py:299:        # for the case of Index, where the repr is traditional rather then
../pandas/tests/groupby/test_grouping.py:391:        # the surprise comes from using key[0:6] rather then str(key)[0:6]

Is it ok if I submitt a PR and assign you as the reviewer?

@MarcoGorelli
Copy link
Member Author

Closed by #31395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants