Skip to content

DOC: Whatsnew for 1.0 has deprecations listed in Enhancements section #30927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dr-Irv opened this issue Jan 11, 2020 · 2 comments · Fixed by #30961
Closed

DOC: Whatsnew for 1.0 has deprecations listed in Enhancements section #30927

Dr-Irv opened this issue Jan 11, 2020 · 2 comments · Fixed by #30961
Labels
Docs good first issue
Milestone
1.0.0

Comments

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jan 11, 2020

In 1.0.0RC0, at https://dev.pandas.io/docs/whatsnew/v1.0.0.html#other-enhancements (i.e., the list of enhancements), we list the following:

  • The pandas.np submodule is now deprecated. Import numpy directly instead (GH30296)
  • The pandas.datetime class is now deprecated. Import from datetime instead (GH30296)

Shouldn't those two lines appear in the deprecations section https://dev.pandas.io/docs/whatsnew/v1.0.0.html#deprecations instead?
@jreback
Copy link
Contributor

jreback commented Jan 11, 2020

yes this needs editing happy to take. PR

@jorisvandenbossche jorisvandenbossche added this to the 1.0.0 milestone Jan 12, 2020
@ryankarlos ryankarlos mentioned this issue Jan 13, 2020
Merged
5 tasks
@ryankarlos
Copy link
Contributor

One of these may have been my fault, sorry - now fixed in open PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs good first issue
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

DOC: Move couple of deprecations whatsnew to correct section ryankarlos/pandas
5 participants
@jreback @jorisvandenbossche @charlesdong1991 @Dr-Irv @ryankarlos