Skip to content

CI: Checks job aborted if a step fails #30298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue Dec 17, 2019 · 4 comments · Fixed by #30303
Closed

CI: Checks job aborted if a step fails #30298

datapythonista opened this issue Dec 17, 2019 · 4 comments · Fixed by #30303
Assignees
Labels
CI Continuous Integration good first issue

Comments

@datapythonista
Copy link
Member

In our job that checks that the code is ok (flake8, mypy...) [1], we want to run all the steps whether any of them fail or not.

This is implemented by using if: true in each step. While this should work, it doesn't. A better way to implement this that probably fixes the issue is to use if: always() instead.

What we should do is:

  • Replace all instances of if: true by if: always in the yaml file.
  • Introduce couple of temporary errors. Something PEP-8 invalid (so flake8 reports the error), and change the order of the imports of a file (so isort reports the error).
  • Open a pull request
  • See if the job behaves as expected, and wait for a code review
  • Once the pull request is approved, revert the errors introduced, so the changes to the yaml file can be merged
  1. https://github.com/pandas-dev/pandas/blob/master/.github/workflows/ci.yml
@datapythonista datapythonista added CI Continuous Integration good first issue labels Dec 17, 2019
@suzutomato
Copy link
Contributor

I'd like to take this.

@datapythonista
Copy link
Member Author

Thanks @suzutomato

You can assign the issue to yourself by writing take in a comment.

@suzutomato
Copy link
Contributor

Sorry, I misunderstood the instruction in the contributing guide.
It had to be exactly "take", not including the exact word "take" in my comment.

@suzutomato
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration good first issue
Projects
None yet
2 participants