Skip to content

Default dtype of empty Series: DeprecationWarning -> FutureWarning in 1.1 #30017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SaturnFromTitan opened this issue Dec 3, 2019 · 4 comments · Fixed by #42587
Closed

Default dtype of empty Series: DeprecationWarning -> FutureWarning in 1.1 #30017

SaturnFromTitan opened this issue Dec 3, 2019 · 4 comments · Fixed by #42587
Labels
Deprecate Functionality to remove in pandas
Milestone

Comments

@SaturnFromTitan
Copy link
Contributor

Given that this can have some impact on libraries (see how often we used it ourselves in pandas), meaning that their users will start to see warnings they cannot solve, should be start with making this a DeprecationWarning instead of FutureWarning?

Given that this won't be actually changed in 1.0 (but only start raising a warning), we have some time to change it to a FutureWarning in a later release.

I guess we could have DeprecationWarning for a single version, then change to FutureWarning to give libraries a chance to change. I feel these are ignored as well by the downstream as they don't see them by-default (we in fact tend to ignore numpy ones :->)

@SaturnFromTitan let's change this and open an issue for the 1.1 milestone (let me create it) to change to a FutureWarning

Originally posted by @jreback in #29405 (comment)

@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Dec 4, 2019
@jbrockmendel jbrockmendel added the Deprecate Functionality to remove in pandas label Dec 11, 2019
@SaturnFromTitan
Copy link
Contributor Author

@jreback Do you think I can work on this yet? 3 minor versions passed, which should be good enough to make this a FutureWarning now.

@TomAugspurger
Copy link
Contributor

Closed by #29405.

@lithomas1
Copy link
Member

@TomAugspurger Did this actually get changed? On my branch off master this still raises DeprecationWarning.

@TomAugspurger
Copy link
Contributor

Not sure.

@lithomas1 lithomas1 reopened this Jul 17, 2021
@lithomas1 lithomas1 removed this from the 1.1 milestone Jul 17, 2021
@jreback jreback added this to the 1.4 milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants