Skip to content

CI: Unify pytest versions across builds #29664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue Nov 17, 2019 · 6 comments · Fixed by #29678
Closed

CI: Unify pytest versions across builds #29664

datapythonista opened this issue Nov 17, 2019 · 6 comments · Fixed by #29678
Assignees
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Milestone

Comments

@datapythonista
Copy link
Member

May be I'm missing something, but is there a reason to use different pytest versions in our CI builds? I see we're using those in the dependencies files:

  • pytest
  • pytest>=4.0.2
  • pytest>=4.0.2,<5.0
  • pytest=4.5.0
  • pytest>=5.0.0
  • pytest>=5.0.1

Since pytest is not a pandas dependency, but just a tool we use, feels like we should just use always the same version (the latest). All those (all versions since pytest 4) support Python >3.6, so I don't think there is any limitation that prevents this.

Am I missing something? Can we always use the same version?

I'm thinking on having a separate file for the tools needed for all builds (pytest, pytest-xdist...), and install both dependency files, the one of the build, and the common one. So we don't have to duplicate those in every file (it's faster to maintain and make changes, and also easier to see what dependencies we have and what we're testing in every build).

@jreback @TomAugspurger does this make sense?

@datapythonista datapythonista added CI Continuous Integration Dependencies Required and optional dependencies labels Nov 17, 2019
@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

you can try but we had a number of issues and that is why they r pinned

@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

-1 on splitting the build files

@datapythonista
Copy link
Member Author

take

@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

lol
it worked!

@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

we need an auto unassigner maybe 2 weeks after no action

@datapythonista
Copy link
Member Author

I agree, I'll probably wait until we have unassigned issues with no activity. Having examples will probably help make better decisions, on timing, what actions we consider...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants