Skip to content

Add Note About Referencing GH Issue Number to Test in Contrib Guide #28703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Oct 1, 2019 · 2 comments · Fixed by #28907
Closed

Add Note About Referencing GH Issue Number to Test in Contrib Guide #28703

WillAyd opened this issue Oct 1, 2019 · 2 comments · Fixed by #28907
Labels
Docs good first issue
Milestone
1.0.0

Comments

@WillAyd
Copy link
Member

WillAyd commented Oct 1, 2019

We often ask people to add the GH Issue number as a comment to new tests, but that requirement isn't explicitly spelled out in the contributing guide. Might save some back and forth if that is added to the Writing Tests section:

https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#writing-tests
@WillAyd WillAyd added this to the Contributions Welcome milestone Oct 1, 2019
@dmswl6310
Copy link

Can I try it??

@KiranAkadas
Copy link

I want to work on this!

@KiranAkadas KiranAkadas mentioned this issue Oct 1, 2019
Closed
1 task
@jreback jreback modified the milestones: Contributions Welcome, 1.0 Oct 1, 2019
@S3rbane S3rbane mentioned this issue Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs good first issue
Projects
None yet
Milestone
1.0.0
4 participants
@WillAyd @jreback @KiranAkadas @dmswl6310