-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WEB: Deployment of the new website in production #28528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Why do we want to deploy daily from master? I feel like that might add a maintenance burden for not a lot of gain |
Currenlty, Tom builds the website manually and uploads it, which means even more burden (for him) + it often does not happen directly after a change. |
@datapythonista in the daily deploy, this can also include the dev docs? (similar to a version: pandas.io/docs/en/dev/) |
I'm mostly concerned about the frequency. Pushing daily changes to a live production documentation system seems like an easy way for mistakes in our development process to impact people trying to use the documentation in the day to day |
Forgot to add it, but that's surely an option, and I'm happy about it.
I'm ok with weekly too. But couple of comments to consider:
|
We will typically not change the website very often (at least not daily), but if we do, we want to have it live quickly (eg for announcing a new release). |
+1 for continuously deploying it whenever the web stuff is touched. |
After a second thought, also +1 on this (immediate fixes, and the CI will be simpler with a single job for all). And if for whatever reason this causes troubles, it should be very easy to change the frequency. Updated the description to show the different options. |
One problem with this "whenever web stuff is touched" is that this heuristic does not work for the dev docs. Currently (for github pages) you first copy website and docs to a single directory, and then rsync both together. But I suppose they can also be rsynced separately? (and then the dev docs on each commit? that's maybe a bit too much?) |
Let's just deploy each commit then :) |
I'd run the I think I don't get what you have in mind. Does what I propose make sense? |
Not sure it fits on this issue, but it has to do with deployment of the docs, so posting here (but can also open a new issue). Now we are starting to use the new deployed web/docs publicly, we still need to decide on a url scheme. I think there are two parts (base url vs doc url scheme), and so the first question is: Which base url do we use? (pandas.pydata.org vs pandas.io)
And a second question (although only applicable if we go with a new base url): what url scheme for the docs to use? |
Ah, and I see now that @datapythonista already mentioned this above, and additionally had the idea to already be future proof and add a |
Whoops, I meant to use https://pandas.pydata.org/pandas-docs/version/1.0.0/ for those. Oh well.
Slight preference for pandas.pydata.org, just since there's so much material referencing that. We would of course redirect if we made the move, so this isn't a huge deal.
@aterrel can hopefully answer that. |
The domains and the hostings are independent, we can use old server with pandas.io, and pandas.pydata.org in the new hosting. I think there was some discussion about using pandas.io when Wes proposed it, and people was happy with it. May be I just assumed it, in any case good to discuss it if anyone has anything to discuss. I'd have pandas.io/docs/ for the docs, being a symlink to the latest version (so, in the server we could have I think all agree that whatever we do, old urls should redirect to the new equivalent urls. I don't think that should be complex, I'd probably redirect pandas.pydata.org to the new server, and configure http headers with the redirects in the load balancer. |
Also a slight preference for pandas.pydata.org for same reasons prescribed by Tom |
Until now, we've been deploying the website manually afaik, from the separate repo.
What I would do with the new website is next (open to discussion):
rsync avz --delete --exclude="docs" ~/web/build [email protected]:/var/www/pandas
For the docs, I see two main options:
docs/
have a directory per language (currently English), and inside them one per version (with a symlinkstable/ -> 0.25.1
), so the urls would be something like pandas.io/docs/en/stable or pandas.io/docs/en/0.24.0 (and redirect pandas.io/docs/ to pandas.io/docs/en/stable)In both cases, we can deploy the master docs into a
dev/
directory together with the versions.I think the first option is a bit simpler to maintain, and the second makes the url a bit simpler. I don't have a strong preference.
I think this is very simple, but requires that all pages that we don't want to version are in the web, and not in the docs. So, if the roadmap is in the docs, the version we will have will be the stable version (0.25.1) and not master.
@jorisvandenbossche you proposed to have the next pages in the docs:
Do you have a proposal for how to serve or deploy these? Or are you ok having the stable version of those? I thought about it, and I couldn't find any option I liked to keep those in the docs, that's why I'm proposing to move them to the website.
The text was updated successfully, but these errors were encountered: