Skip to content

Naming Convention for Type Aliases #28480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vaibhavhrt opened this issue Sep 17, 2019 · 2 comments
Closed

Naming Convention for Type Aliases #28480

vaibhavhrt opened this issue Sep 17, 2019 · 2 comments
Labels
Typing type annotations, mypy/pyright type checking

Comments

@vaibhavhrt
Copy link
Contributor

A consistent naming convention should be used for type aliases.
Maybe CamelCase as the stdlib typing module is in Camel Case, but suggestions are welcome.

Inconsistent names could be found in pandas.io.formatters.formatter, formatters_type and float_format_type. Look for other similar names too and fix them all.
@vaibhavhrt
Copy link
Contributor Author

I will open a PR after a few days. Meanwhile someone else is welcome to pick it up.

@vaibhavhrt vaibhavhrt mentioned this issue Sep 17, 2019
Merged
5 tasks
@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Sep 17, 2019
@jbrockmendel jbrockmendel changed the title Naming Convension for Type Aliases Naming Convention for Type Aliases Feb 25, 2020
@xcz011 xcz011 mentioned this issue Feb 29, 2020
Merged
5 tasks
@mroeschke
Copy link
Member

Thanks for the request, but it appears this hasn't gain traction in a while so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mroeschke @simonjayhawkins @vaibhavhrt