Skip to content

Functions allowed in DataFrameGroupby.transform are not all tested #27905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
charlesdong1991 opened this issue Aug 13, 2019 · 5 comments
Closed

Functions allowed in DataFrameGroupby.transform are not all tested #27905

charlesdong1991 opened this issue Aug 13, 2019 · 5 comments
Labels
good first issue Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite

Comments

@charlesdong1991
Copy link
Member

charlesdong1991 commented Aug 13, 2019 •
edited
Loading

e.g. fillna, tshiftand corrwith are all allowed in group.transform(), but looking at pandas/tests/groupby/test_transform.py, they are not tested. There are more, and I will add to here and make a PR to tests these cases.
@ukantesaria ukantesaria mentioned this issue Aug 18, 2019
Closed
5 tasks
@ukantesaria ukantesaria mentioned this issue Sep 8, 2019
Closed
5 tasks
@jreback jreback added Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite labels Sep 8, 2019
@jreback jreback added this to the 1.0 milestone Oct 5, 2019
@TomAugspurger
Copy link
Contributor

Looks like #27974 was closed as stale. Marking as a good first issue, if anyone wants to pick it up based on that PR.

@TomAugspurger TomAugspurger modified the milestones: 1.0, Contributions Welcome Dec 30, 2019
@lfiedler
Copy link

lfiedler commented Jan 8, 2020

Hi, I would like to work on this.

@ryankarlos ryankarlos mentioned this issue Feb 18, 2020
Closed
4 tasks
@echozzy629
Copy link

Hi, I would like to work on this.

@simonjayhawkins
Copy link
Member

@echozzy629 Thanks for the interest. #32069 has been submitted to address this issue.

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Mar 3, 2020 •
edited
Loading

superseded by #32293 , #31269 , #27472 and #32344, see #32069 (comment)

@simonjayhawkins simonjayhawkins modified the milestones: Contributions Welcome, No action Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
6 participants
@jreback @TomAugspurger @lfiedler @charlesdong1991 @simonjayhawkins @echozzy629