Skip to content

INT: avoid accessing self.loc._foo outside of indexing.py #27344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Jul 11, 2019 · 1 comment
Closed

INT: avoid accessing self.loc._foo outside of indexing.py #27344

jbrockmendel opened this issue Jul 11, 2019 · 1 comment
Labels
Clean Internals Related to non-user accessible pandas implementation

Comments

@jbrockmendel
Copy link
Member

grepping for .loc. and .iloc. I see two uses of self.loc._convert_to_indexer and two uses of self.loc._setitem_with_indexer in core.frame, and two uses of obj.loc._getitem_axis in io.pytables
@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Jul 12, 2019
@jbrockmendel jbrockmendel mentioned this issue Jul 14, 2019
Merged
@topper-123
Copy link
Contributor

This reminds me: the indexers all have their name prepebded wirh a _:

  • _LocIndexer
  • _IlocIndexer
  • _AtIndexer
  • _IatIndexer
  • etc.

They are not actually private, so sholdnt we rename them (drop the _)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @gfyoung @topper-123