Line Length Specification in Contributing Documentation

[WillKoehrsen]

Reading the contributing documentation section on pep8, I noticed the acceptable line-length for Python code is given as 79 characters as specified in pep8.

we restrict line-length to 79 characters to promote readability

However, looking at setup.cfg, I see that the maximum line length is specified as 88 characters and flake8 is set up to ignore line length errors.

[flake8]
max-line-length = 88
ignore =
    E501,  # longer line length

Is the contributing documentation out-of-date, or am I making an incorrect interpretation of setup.cfg?

[jreback]

setup.cfg should be changed (this was changed previously but not changed back), PR welcome

black enforces this now so the flake check doesn’t really do anything (for like length)

[jorisvandenbossche]

I opened #27226 for updating the contributing guide (and initial PR: #27233)