Skip to content

CI: Improve codecov reporting #26896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
datapythonista opened this issue Jun 16, 2019 · 2 comments · Fixed by #27066
Closed

CI: Improve codecov reporting #26896

datapythonista opened this issue Jun 16, 2019 · 2 comments · Fixed by #27066
Labels
CI Continuous Integration good first issue Testing pandas testing functions or related to the test suite
Milestone
0.25.0

Comments

@datapythonista
Copy link
Member

Codecov is adding two comments to our PRs after the tests are successfully run. Which makes us receive two messages. Personally I don't find these useful. I see that other projects have codecov in the checks, next to the builds (expand the "All checks have passed" in xhochy/fletcher#74 to see an example).

Is other people finding those comments/messages useful? Would be enough for you to just have the info in the list of checks and no emails?

xref #12634
@datapythonista datapythonista added Testing pandas testing functions or related to the test suite CI Continuous Integration Needs Discussion Requires discussion from core team before further action labels Jun 16, 2019
@jreback
Copy link
Contributor

jreback commented Jun 16, 2019

+1 on this
the messages are confusing / less than useful

@datapythonista datapythonista added Effort Low good first issue and removed Needs Discussion Requires discussion from core team before further action labels Jun 16, 2019
@jorisvandenbossche
Copy link
Member

+1

Additionally, codecov gives simply useless / wrong feedback more often than not.
Many times that I want to check the code coverage of a PR, it often even doesn't load on their website.

@mroeschke mroeschke mentioned this issue Jun 26, 2019
Merged
1 task
@jreback jreback added this to the 0.25.0 milestone Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

CI: Disable codecov comments and re-enable results in the checks mroeschke/pandas
3 participants
@jreback @jorisvandenbossche @datapythonista