-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REF: avoid using concat
in __repr__
#26863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you explain a bit more why you think this is bad? |
In the motivating example, in a WIP branch I managed to screw up My intuition is that concat is overkill for this particular usage and we can simplify the dependency structure here. |
I am not sure that is desirable / possible to avoid in practice. The concat ensures that the values above and below the truncation are formatted together, which is important for a consistent formatting (I remember bugs about this). |
you might be able to use an iloc / |
I trust Joris if he says this is needed; closing. @jorisvandenbossche could use your input on #26864. |
ATM
DataFrame.__repr__
takes a path throughio.formats.format.DataFrameFormatter._chk_truncate
that can callcore.reshape.concat.concat
. Similar forSeries.__repr__
. It would be really nice if we could avoid that and find a simpler way to do this.The text was updated successfully, but these errors were encountered: