Skip to content

Performance for TimedeltaArray.__iter__ and PeriodArray.__iter__ #26713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Jun 7, 2019 · 1 comment · Fixed by #36551
Closed

Performance for TimedeltaArray.__iter__ and PeriodArray.__iter__ #26713

TomAugspurger opened this issue Jun 7, 2019 · 1 comment · Fixed by #36551
Labels
Datetime Datetime data dtype Performance Memory or execution speed performance
Milestone
1.2

Comments

@TomAugspurger
Copy link
Contributor

Right now DatetimeArray.__iter__ does it's boxing in chunks. We could do something similar for TimedeltaArray and possibly PeriodArray.
@TomAugspurger TomAugspurger added Datetime Datetime data dtype Performance Memory or execution speed performance labels Jun 7, 2019
@TomAugspurger TomAugspurger added this to the Contributions Welcome milestone Jun 7, 2019
@TomAugspurger TomAugspurger mentioned this issue Jun 7, 2019
Merged
4 tasks
@jbrockmendel
Copy link
Member

There is a tslibs.timedeltas.ints_to_pytimedelta(arr.asi8, box=True) that will make this easy to do for Timedelta; nothing analogous for Period

@jbrockmendel jbrockmendel mentioned this issue Sep 22, 2020
Merged
5 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype Performance Memory or execution speed performance
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

PERF: TimedeltaArray.__iter__ jbrockmendel/pandas
3 participants
@jreback @TomAugspurger @jbrockmendel